-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: allow insert default
into generated columns
#11901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11901 +/- ##
===========================================
Coverage 81.3215% 81.3215%
===========================================
Files 443 443
Lines 95286 95286
===========================================
Hits 77488 77488
Misses 12309 12309
Partials 5489 5489 |
6ec0a0a
to
6836ab6
Compare
/run-all-tests |
/run-all-tests |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Deardrops Do we have the plan to support |
Yes, we have open a issue for this problem #11939 |
/run-all-tests |
What problem does this PR solve?
In MySQL document,
What is changed and how it works?
Allow use the
DEFAULT
keyword when insert into the generated columns.When build the
insert plan
, check ifDEFAULT
Skip add this column's expression into this
insert plan
.Because we can't insert value into generated clumns directly, it's acceptable to ignore the generated column in
insert plan
.Check List
Tests
Release note
DEFAULT
keyword when insert into the generated columns.