stats: limit the number of top-n items #11906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #11906 +/- ##
===========================================
Coverage ? 81.2248%
===========================================
Files ? 438
Lines ? 94236
Branches ? 0
===========================================
Hits ? 76543
Misses ? 12229
Partials ? 5464 |
lzmhhh123
reviewed
Aug 28, 2019
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Aug 28, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
The root cause is that analyze will generate topn items much more than expected, because we regard one item as topn as long as it occurs more than
lasttimes and does not limit the number of topn.This PR fixes it by limit the number of topn.
Check List
Tests
Code changes
Side effects
Related changes
Release note