Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: support display invalid key in stats buckets (#12064) #12094

Merged
merged 8 commits into from
Sep 12, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 9, 2019

cherry-pick #12064 to release-3.0


What problem does this PR solve?

show stats_buckets sometimes shows errors like invalid encoded key flag 252.

What is changed and how it works?

Feedback may generate invalid index keys, we need to handle these when trying to display values instead of raise errors.

Check List

Tests

  • Unit test
    Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • support display invalid key in stats buckets

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 9, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2019
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

@sre-bot merge failed.

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

Your auto merge job has been accepted, waiting for #11953, #12052, #11957

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 10, 2019

@sre-bot merge failed.

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 11, 2019

Your auto merge job has been accepted, waiting for #12127

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 11, 2019

@sre-bot merge failed.

@zz-jason
Copy link
Member

/rebuild

@zz-jason zz-jason merged commit 299da1b into pingcap:release-3.0 Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants