-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: support display invalid key in stats buckets (#12064) #12094
stats: support display invalid key in stats buckets (#12064) #12094
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for #12127 |
/run-all-tests |
@sre-bot merge failed. |
/rebuild |
cherry-pick #12064 to release-3.0
What problem does this PR solve?
show stats_buckets
sometimes shows errors likeinvalid encoded key flag 252
.What is changed and how it works?
Feedback may generate invalid index keys, we need to handle these when trying to display values instead of raise errors.
Check List
Tests
Unit test
Code changes
Has exported function/method change
Side effects
Related changes
Release note