Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: disallow dropping auto_increment column attribute (#12107) #12146

Merged
merged 4 commits into from
Sep 12, 2019
Merged

ddl: disallow dropping auto_increment column attribute (#12107) #12146

merged 4 commits into from
Sep 12, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #12107

jackysp
jackysp reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

/run-all-tests

Deardrops
Deardrops approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.

@bb7133 bb7133 added the status/LGT3 The PR has already had 3 LGTM. label Sep 11, 2019
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

Your auto merge job has been accepted, waiting for 12035, 12128

@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

@tangenta merge failed.

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason
Copy link
Member

/rebuild

@zz-jason zz-jason merged commit 9059790 into pingcap:release-2.1 Sep 12, 2019
@tangenta tangenta mentioned this pull request Sep 12, 2019
Merged
@aytrack aytrack mentioned this pull request Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@bb7133 bb7133 bb7133 left review comments

@Deardrops Deardrops Deardrops approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tangenta @sre-bot @zz-jason @bb7133 @jackysp @Deardrops