-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: add sql to com_exec/com_fetch dispatch error log (#12174) #12191
Merged
sre-bot
merged 5 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-57735957a2e2
Sep 17, 2019
Merged
server: add sql to com_exec/com_fetch dispatch error log (#12174) #12191
sre-bot
merged 5 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-57735957a2e2
Sep 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
jackysp
reviewed
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
tiancaiamao
approved these changes
Sep 17, 2019
jackysp
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 17, 2019
/run-all-tests |
@sre-bot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for 12227 |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #12174 to release-3.0
What problem does this PR solve?
More and more user use prepare stmt, but current dispatch error log we only can see packet binary info, we don't know which sql meet error.
What is changed and how it works?
add sql to error thrown in handleStmtExec and handleStmtFetch
after this PR, we can got
("select 1" now is in last, we can modify pingcap/errors to let be in front, but we need add msg first)
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is