Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: fix out-of-index in split-region #12265

Merged
merged 4 commits into from
Sep 19, 2019
Merged

tikv: fix out-of-index in split-region #12265

merged 4 commits into from
Sep 19, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 18, 2019

What problem does this PR solve?

simple fix "out of index" error when split reponse's region num be zero and want to write info log.

x1

What is changed and how it works?

check region num and avoid out of index error

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • n/a

Side effects

  • n/a

Related changes

  • n/a

Release note

  • n/a

/cc @breeswish


This change is Reviewable

@lysu lysu added type/bugfix This PR fixes a bug. component/tikv labels Sep 18, 2019
@lysu
Copy link
Contributor Author

lysu commented Sep 18, 2019

/run-all-tests

@lysu lysu requested review from zimulala and jackysp September 18, 2019 10:02
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #12265 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12265   +/-   ##
===========================================
  Coverage   81.2292%   81.2292%           
===========================================
  Files           454        454           
  Lines         99506      99506           
===========================================
  Hits          80828      80828           
  Misses        12885      12885           
  Partials       5793       5793

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2019
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit f792e8d into pingcap:master Sep 19, 2019
@july2993
Copy link
Contributor

july2993 commented Nov 2, 2019

@lysu need pick to release-3.0, I encounter this with 3.0.5 and the latest release-3.0 still not fixed.

@lysu
Copy link
Contributor Author

lysu commented Nov 3, 2019

/run-cherry-picker

@crazycs520
Copy link
Contributor

@lysu need cherry-pick to 3.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants