planner/core: fix resolve rule for group by expression #12307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #12307 +/- ##
===========================================
Coverage 81.2598% 81.2598%
===========================================
Files 454 454
Lines 99807 99807
===========================================
Hits 81103 81103
Misses 12915 12915
Partials 5789 5789 |
lysu
added
status/LGT2
lysu
approved these changes
Sep 24, 2019
|
Your auto merge job has been accepted, waiting for 12318 |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #12351 |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 in PR #12354 |
sre-bot
added a commit
that referenced
this pull request
Sep 24, 2019
sre-bot
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When there is paramemter markers in group by, it should be only treated as position expression when it is in top level and it is a constant uint.
What is changed and how it works?
Change the resolve rule for group by expressions.
Check List
Tests
Code changes
Side effects
Related changes
Release note
GroupByexpressions in prepare statemet.