executor: fix bug about JSON_EXTRACT fails to cast as bool #12440

tsthght · 2019-09-27T08:14:29Z

What problem does this PR solve?

fix bug about JSON_EXTRACT fails to cast as bool #12233
@ngaut

What is changed and how it works?

create database testjson;
use testjson;
create table testjson( id int auto_increment not null primary key, j json )default charset=utf8 engine=innodb;
insert into testjson set j='{"test":1}';
select id from testjson where json_extract(j, '$.test');
+----+
| id |
+----+
|  1 |
+----+
1 row in set (0.001 sec)

Check List

Tests

Unit test

codecov · 2019-09-27T08:19:42Z

Codecov Report

Merging #12440 into master will decrease coverage by 0.3721%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master    #12440        +/-   ##
===============================================
- Coverage   80.3452%   79.973%   -0.3722%     
===============================================
  Files           465       465                
  Lines        108396    106257      -2139     
===============================================
- Hits          87091     84977      -2114     
+ Misses        14952     14944         -8     
+ Partials       6353      6336        -17

SunRunAway

Thanks for your PR, I've left some comments, PTAL

SunRunAway · 2019-09-29T11:08:54Z

types/datum.go

@@ -1390,6 +1390,8 @@ func (d *Datum) ToBool(sc *stmtctx.StatementContext) (int64, error) {
 	case KindBinaryLiteral, KindMysqlBit:
 		val, err1 := d.GetBinaryLiteral().ToInt(sc)
 		isZero, err = val == 0, err1
+	case KindMysqlJSON:
+		isZero, err = d.IsNull(), nil


It should be false if $.test is zero.
Please add a test case like {"test":0} to cover it.

I had add testcase as follows:
a) testcase1:
insert into testjson set j='{"test":0}
select j from testjson where json_extract(j, '$.test')

b) testcase2:
insert into testjson set j='{"test1":0}
select j from testjson where json_extract(j, '$.test')

I've tested this case in Mysql5.7, and the result is different from yours.

mysql> drop table testjson; Query OK, 0 rows affected (0.00 sec) mysql> create table testjson(j json ); Query OK, 0 rows affected (0.01 sec) mysql> insert into testjson set j='{"test":0}'; Query OK, 1 row affected (0.00 sec) mysql> select j from testjson where json_extract(j, '$.test'); Empty set (0.00 sec)

Another case is different from Mysql5.7

In your branch:

mysql> create table testjson(j json); Query OK, 0 rows affected (0.01 sec) mysql> insert into testjson set j='0'; Query OK, 1 row affected (0.00 sec) mysql> insert into testjson set j='null'; Query OK, 1 row affected (0.00 sec) mysql> insert into testjson set j='1'; Query OK, 1 row affected (0.00 sec) mysql> select j from testjson where j; +------+ | j | +------+ | 0 | | null | | 1 | +------+ 3 rows in set (0.00 sec)

In MySQL5.7

mysql> create table testjson(j json); Query OK, 0 rows affected (0.02 sec) mysql> insert into testjson set j='0'; Query OK, 1 row affected (0.01 sec) mysql> insert into testjson set j='null'; Query OK, 1 row affected (0.00 sec) mysql> insert into testjson set j='1'; Query OK, 1 row affected (0.00 sec) mysql> select j from testjson where j; +------+ | j | +------+ | 1 | +------+ 1 row in set, 1 warning (0.00 sec) mysql> show warnings; +---------+------+---------------------------------------------------------------+ | Level | Code | Message | +---------+------+---------------------------------------------------------------+ | Warning | 3156 | Invalid JSON value for CAST to INTEGER from column j at row 2 | +---------+------+---------------------------------------------------------------+ 1 row in set (0.00 sec)

Thank you, I will investigate it.

SunRunAway · 2019-09-29T11:09:15Z

executor/executor_test.go

@@ -1850,6 +1850,12 @@ func (s *testSuiteP1) TestGeneratedColumnRead(c *C) {
 	result = tk.MustQuery(`SELECT * FROM test_gc_read_m`)
 	result.Check(testkit.Rows(`1 2 4`, `2 3 6`))

+	// Test for issue #12233
+	tk.MustExec(`create table testjson( id int auto_increment not null primary key, j json )default charset=utf8 engine=innodb;`)


Could you simplify this table schema?

Thank you. I had simplified the table schema.

executor/executor_test.go

SunRunAway · 2019-09-29T13:01:47Z

executor/executor_test.go

@@ -1850,6 +1850,12 @@ func (s *testSuiteP1) TestGeneratedColumnRead(c *C) {
 	result = tk.MustQuery(`SELECT * FROM test_gc_read_m`)
 	result.Check(testkit.Rows(`1 2 4`, `2 3 6`))

+	// Test for issue #12233


Please do not put it in TestGeneratedColumnRead

thank you. I had removed this comment.

Sorry, maybe you don't get me.

Your test case is in TestGeneratedColumnRead, but it should not be here.

tsthght · 2019-10-15T08:24:17Z

/rebuild

tsthght · 2019-10-18T00:32:05Z

/rebuild

zyxbest · 2019-10-18T03:23:58Z

/run-check_dev

Deardrops · 2019-12-03T02:28:54Z

@tsthght Friendly ping, any update for this PR?

sre-bot · 2020-01-04T13:48:37Z

@tsthght, please update your pull request.

sre-bot · 2020-01-11T13:49:10Z

@tsthght, please update your pull request.

sre-bot · 2020-01-27T13:47:22Z

@tsthght PR closed due to no update for a long time. Feel free to reopen it anytime.

executor: fix bug about JSON_EXTRACT fails to cast as bool

35acaff

sre-bot added the contribution This PR is from a community contributor. label Sep 27, 2019

Merge branch 'master' into json

530dcf1

zz-jason added the component/expression label Sep 28, 2019

zz-jason requested review from qw4990 and SunRunAway September 28, 2019 02:17

tsthght added 3 commits September 28, 2019 21:02

Merge branch 'master' into json

3d221a2

Merge branch 'master' into json

ba9bd83

Merge branch 'master' into json

3ba2d94

SunRunAway reviewed Sep 29, 2019

View reviewed changes

Reminiscent mentioned this pull request Oct 9, 2019

expression: make the selection executor support vectorized expression evaluation #12220

Merged

tsthght added 4 commits October 15, 2019 13:51

Remove the comment

c923a74

simplify table schema of testcase

7ee20ee

add more testcase

c257140

Merge branch 'master' into json

9c55c6c

Merge branch 'master' into json

30ea18f

add space

3c5949b

qw4990 removed their request for review November 26, 2019 07:33

zz-jason added the status/ReqChange label Dec 28, 2019

sre-bot closed this Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: fix bug about JSON_EXTRACT fails to cast as bool #12440

executor: fix bug about JSON_EXTRACT fails to cast as bool #12440

tsthght commented Sep 27, 2019 •

edited by Deardrops

Loading

codecov bot commented Sep 27, 2019 •

edited

Loading

SunRunAway left a comment

SunRunAway Sep 29, 2019 •

edited

Loading

tsthght Oct 15, 2019

SunRunAway Oct 18, 2019

SunRunAway Oct 18, 2019

tsthght Oct 18, 2019

SunRunAway Sep 29, 2019

tsthght Oct 15, 2019

SunRunAway Sep 29, 2019

tsthght Oct 15, 2019

SunRunAway Oct 18, 2019

tsthght commented Oct 15, 2019

tsthght commented Oct 18, 2019

zyxbest commented Oct 18, 2019

Deardrops commented Dec 3, 2019 •

edited

Loading

sre-bot commented Jan 4, 2020

sre-bot commented Jan 11, 2020

sre-bot commented Jan 27, 2020

executor: fix bug about JSON_EXTRACT fails to cast as bool #12440

executor: fix bug about JSON_EXTRACT fails to cast as bool #12440

Conversation

tsthght commented Sep 27, 2019 • edited by Deardrops Loading

What problem does this PR solve?

What is changed and how it works?

Check List

codecov bot commented Sep 27, 2019 • edited Loading

Codecov Report

SunRunAway left a comment

Choose a reason for hiding this comment

SunRunAway Sep 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsthght commented Oct 15, 2019

tsthght commented Oct 18, 2019

zyxbest commented Oct 18, 2019

Deardrops commented Dec 3, 2019 • edited Loading

sre-bot commented Jan 4, 2020

sre-bot commented Jan 11, 2020

sre-bot commented Jan 27, 2020

tsthght commented Sep 27, 2019 •

edited by Deardrops

Loading

codecov bot commented Sep 27, 2019 •

edited

Loading

SunRunAway Sep 29, 2019 •

edited

Loading

Deardrops commented Dec 3, 2019 •

edited

Loading