planner: stream agg should not be pushed to double read #12443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis0407
reviewed
Sep 27, 2019
| } else { | ||
| partialAgg.SetChildren(cop.indexPlan) | ||
| cop.indexPlan = partialAgg | ||
| if cop.extraHandleCol == nil { |
There was a problem hiding this comment.
Could you please add a comment here to explain the reason? I think it may be hard to understand without this PR's description.
Codecov Report
@@ Coverage Diff @@
## master #12443 +/- ##
================================================
- Coverage 79.8628% 79.6481% -0.2147%
================================================
Files 461 461
Lines 103803 101465 -2338
================================================
- Hits 82900 80815 -2085
- Misses 14813 14827 +14
+ Partials 6090 5823 -267 |
|
Please fix the explain tests. |
alivxxx
reviewed
Oct 8, 2019
lzmhhh123
reviewed
Oct 9, 2019
Co-Authored-By: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>
|
/run-all-tests |
|
LGTM |
francis0407
added
status/can-merge
|
/run-all-tests |
|
@winoros merge failed. |
|
/merge |
|
/run-all-tests |
lzmhhh123
approved these changes
Oct 12, 2019
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Oct 14, 2019
For the following two reason, we should not push stream agg down to double read - The aggregate will lost the handle information - There's no sort operator. The second read is ordered with pk, not by index.
eurekaka
pushed a commit
that referenced
this pull request
Oct 28, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
For the following two reason, we should not push stream agg down to double read - The aggregate will lost the handle information - There's no sort operator. The second read is ordered with pk, not by index.
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @winoros PTAL. |
12 tasks
This was referenced Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For the following two reason, we should not push stream agg down to double read
What is changed and how it works?
Disable it.
Check List
Tests
Related changes
Release note