Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the set's default value where create table (#12267) #12451

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 27, 2019

cherry-pick #12267 to v3.1

@zimulala
Copy link
Contributor Author

PTAL @zhexuany @bb7133 @crazycs520

@zimulala
Copy link
Contributor Author

/run-unit-test

1 similar comment
@lonng
Copy link
Contributor

lonng commented Sep 29, 2019

/run-unit-test

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

Sorry @crazycs520, you don't have permission to trigger auto merge event on this branch.

@crazycs520
Copy link
Contributor

/run-all-tests

@zimulala zimulala merged commit 1877cb7 into pingcap:release-3.1 Sep 30, 2019
@zimulala zimulala deleted the set-3.1 branch September 30, 2019 08:04
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants