ddl: fix the set's default value where create table (#12267)
#12468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
added
the
status/can-merge
|
Sorry @crazycs520, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
zhexuany
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
LGTM
The PR is failed to pass mysql-test.
The following is error msg:
2019-09-29T06:16:03.029Z] 2019/09/29 14:16:02.567 main.go:693: [fatal] run test [type_timestamp] err: sql:ALTER TABLE t1 ADD c2 TIMESTAMP DEFAULT '2012-02-00';: failed to run query
[2019-09-29T06:16:03.029Z] "ALTER TABLE t1 ADD c2 TIMESTAMP DEFAULT '2012-02-00';"
[2019-09-29T06:16:03.029Z] around line 323,
[2019-09-29T06:16:03.029Z] we need(108):
[2019-09-29T06:16:03.029Z] ALTER TABLE t1 ADD c2 TIMESTAMP DEFAULT '2012-02-00';
[2019-09-29T06:16:03.029Z] Error 1048: invalid default value - [types:1292]invali
[2019-09-29T06:16:03.029Z] but got(108):
[2019-09-29T06:16:03.029Z] ALTER TABLE t1 ADD c2 TIMESTAMP DEFAULT '2012-02-00';
[2019-09-29T06:16:03.029Z] Error 1292: invalid time format: '{2012 2 0 0 0 0 0}'
It seems has nothing to do with this PR.
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@zimulala merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #12267 to v2.1