Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: update's select should not change the output columns #12476

Merged
merged 2 commits into from
Sep 29, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Sep 29, 2019

What problem does this PR solve?

Output columns should change after the select is built.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Write release note for bug-fix or new feature.

@winoros winoros changed the title update's select should not change the output columns planner: update's select should not change the output columns Sep 29, 2019
@winoros winoros added sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Sep 29, 2019
@winoros
Copy link
Member Author

winoros commented Sep 29, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/run-common-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/run-integration-common-test

@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

Merging #12476 into master will decrease coverage by 0.2793%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #12476        +/-   ##
================================================
- Coverage   80.0557%   79.7764%   -0.2794%     
================================================
  Files           461        462         +1     
  Lines        103649     102341      -1308     
================================================
- Hits          82977      81644      -1333     
- Misses        14751      14809        +58     
+ Partials       5921       5888        -33

@winkyao
Copy link
Contributor

winkyao commented Sep 29, 2019

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Sep 29, 2019

/run-common-test

@winoros
Copy link
Member Author

winoros commented Sep 29, 2019

/run-integration-common-test

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6169553 into pingcap:master Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants