expression: QUARTER/DATE_FORMAT compatibility with mysql for 0/0.0 values

[ekalinin]

What problem does this PR solve?

Partial fix for the #11203 (+ #11223 as a global issue, + #9728)

What is changed and how it works?

Added corner cases into builtinCastIntAsTimeSig/builtinCastDecimalAsTimeSig.
If the original value is 0 or 0.0 then it converted as empty Time struct (not a NULL value).

builtinQuarterSig.evalInt checks if we have zero date and it's not not a NULL after casting then we return 0, not NULL.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Code changes

• internal methods only

Side effects

• Breaking backward compatibility?

Related changes

• Need to update the documentation

Release note

• Write release note for bug-fix.

[ekalinin]

TiDB now works for 0 | 0.0 as mysql:
Schema (MySQL v5.7)

---

Query #1

select quarter(0), quarter(0.0), quarter("0000-00-00"), quarter("0000-00-00 00:00:00");

quarter(0)	quarter(0.0)	quarter("0000-00-00")	quarter("0000-00-00 00:00:00")
0	0	null	null

---

Query #2

show warnings;

Level	Code	Message
Warning	1292	Incorrect datetime value: '0000-00-00'
Warning	1292	Incorrect datetime value: '0000-00-00 00:00:00'

---

View on DB Fiddle

[qw4990]

/run-unit-test

[codecov]

Codecov Report

Merging #12488 into master will increase coverage by 0.5494%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12488        +/-   ##
================================================
+ Coverage   80.1169%   80.6663%   +0.5494%     
================================================
  Files           469        469                
  Lines        112045     114500      +2455     
================================================
+ Hits          89767      92363      +2596     
+ Misses        15320      15207       -113     
+ Partials       6958       6930        -28

[SunRunAway]

Hi, thank you for the pr. I've left some comments, PTAL.

[ekalinin]

It looks like DATE_FORMAT is already fixed:

Schema (MySQL v5.7)

mysql> 
    select DATE_FORMAT(0, '%W'), 
           DATE_FORMAT(0.0, '%W'), 
           DATE_FORMAT('0', '%W'), 
           DATE_FORMAT('0.0', '%W'),
           DATE_FORMAT('0000-00-00', '%W');

| DATE_FORMAT(0, '%W') | DATE_FORMAT(0.0, '%W') | DATE_FORMAT('0', '%W') | DATE_FORMAT('0.0', '%W') | DATE_FORMAT('0000-00-00', '%W') |
| -------------------- | ---------------------- | ---------------------- | ------------------------ | ------------------------------- |
|                 NULL |                   NULL |                   NULL |                     NULL |                            NULL |

mysql>    show warnings;

| Level   | Code | Message                                |
| ------- | ---- | -------------------------------------- |
| Warning | 1292 | Incorrect datetime value: '0'          |
| Warning | 1292 | Incorrect datetime value: '0.0'        |
| Warning | 1292 | Incorrect datetime value: '0000-00-00' |

View on DB Fiddle

TiDB:

mysql> select DATE_FORMAT(0, '%W'), DATE_FORMAT(0.0, '%W'), DATE_FORMAT('0', '%W'), DATE_FORMAT('0.0', '%W'), DATE_FORMAT('0000-00-00', '%W %M');
+----------------------+------------------------+------------------------+--------------------------+------------------------------------+
| DATE_FORMAT(0, '%W') | DATE_FORMAT(0.0, '%W') | DATE_FORMAT('0', '%W') | DATE_FORMAT('0.0', '%W') | DATE_FORMAT('0000-00-00', '%W %M') |
+----------------------+------------------------+------------------------+--------------------------+------------------------------------+
| NULL                 | NULL                   | NULL                   | NULL                     | NULL                               |
+----------------------+------------------------+------------------------+--------------------------+------------------------------------+
1 row in set, 5 warnings (0.00 sec)

mysql> show warnings;
+---------+------+--------------------------------------------------------+
| Level   | Code | Message                                                |
+---------+------+--------------------------------------------------------+
| Warning | 1292 | Incorrect datetime value: '0000-00-00 00:00:00'        |
| Warning | 1292 | Incorrect datetime value: '0000-00-00 00:00:00'        |
| Warning | 1292 | invalid time format: '0'                               |
| Warning | 1292 | invalid time format: '0.0'                             |
| Warning | 1292 | Incorrect datetime value: '0000-00-00 00:00:00.000000' |
+---------+------+--------------------------------------------------------+
5 rows in set (0.00 sec)

So i just fixed warnings for 0/0.0 values and added more tests.

[ekalinin]

PTAL

[SunRunAway]

Hi, sorry for the late reply, we've taken a long vacation and back to work now.
I've left some comments again, PTAL. Thanks.

[ekalinin]

0.0* fixed.

[zz-jason]

LGTM

[sre-bot]

Your auto merge job has been accepted, waiting for 13014, 12827, 13181, 13088

[sre-bot]

/run-all-tests

[sre-bot]

@ekalinin merge failed.

[sykp241095]

/run-unit-test

[sre-bot]

cherry pick to release-2.1 failed

[sre-bot]

cherry pick to release-3.0 failed

[sre-bot]

cherry pick to release-3.1 failed

[sre-bot]

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @SunRunAway PTAL.