Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: adjust delta schema count and add metrics (#11625) #12502

Merged
merged 1 commit into from
Oct 8, 2019
Merged

*: adjust delta schema count and add metrics (#11625) #12502

merged 1 commit into from
Oct 8, 2019

Conversation

zimulala
Copy link
Contributor

Cherry-pick #11625 to v3.0

@zimulala
Copy link
Contributor Author

PTAL @tiancaiamao @jackysp @crazycs520

jackysp
jackysp reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

Your auto merge job has been accepted, waiting for 12411

@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

/run-all-tests

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 3, 2019
crazycs520
crazycs520 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2019
@jackysp jackysp added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

Your auto merge job has been accepted, waiting for 12485, 12523, 12522, 12521, 12520

@jackysp jackysp merged commit cd579dd into pingcap:release-3.0 Oct 8, 2019
@zimulala zimulala deleted the schema-cache-3.0 branch October 10, 2019 07:37
zimulala added a commit to zimulala/tidb that referenced this pull request Oct 10, 2019
@zimulala
*: adjust delta schema count and add metrics (pingcap#11625) (pingcap…
7c56347 
…#12502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @sre-bot @tiancaiamao @jackysp @crazycs520