-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick follower read to TiDB (#11347) #12535
Cherry pick follower read to TiDB (#11347) #12535
Conversation
@sunxiaoguang Please help check. |
/run-common-test tidb-test=pr/906 |
Looks like build.sh is trying to verify kvproto version which caused common test to fail. What can we do about this? @qrr1995 |
/run-common-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for code change
…erry_pick_follower_read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick #11347 to 3.1
Fix code conflicts from 4.0 to 3.1. Users can use
tidb_replica_read
session variable to choose reading from leader or follower. To make it consistent with existing behavior, leader will be used by default unless follower is explicitly specified otherwise.Add a session scope variable
tidb_replica_read
to specify if TiDB should read data from leader or follower.