Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick follower read to TiDB (#11347) #12535

Merged
merged 5 commits into from
Oct 12, 2019
Merged

Cherry pick follower read to TiDB (#11347) #12535

merged 5 commits into from
Oct 12, 2019

Conversation

shldreams
Copy link

@shldreams shldreams commented Oct 8, 2019

cherry pick #11347 to 3.1

Fix code conflicts from 4.0 to 3.1. Users can use tidb_replica_read session variable to choose reading from leader or follower. To make it consistent with existing behavior, leader will be used by default unless follower is explicitly specified otherwise.

Add a session scope variable tidb_replica_read to specify if TiDB should read data from leader or follower.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 8, 2019
@shldreams
Copy link
Author

@sunxiaoguang Please help check.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2019

CLA assistant check
All committers have signed the CLA.

@zyxbest
Copy link
Contributor

zyxbest commented Oct 9, 2019

/run-common-test tidb-test=pr/906

@sunxiaoguang
Copy link
Contributor

/run-common-test tidb-test=pr/906

Looks like build.sh is trying to verify kvproto version which caused common test to fail. What can we do about this? @qrr1995

@zz-jason
Copy link
Member

/run-common-test

@zz-jason
Copy link
Member

/run-all-tests

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code change

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2019
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7459d01 into pingcap:release-3.1 Oct 12, 2019
@lonng lonng added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv contribution This PR is from a community contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants