stats: fix shallow copy bugs #12691
Merged
stats: fix shallow copy bugs #12691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #12691 +/- ##
===========================================
Coverage 80.4244% 80.4244%
===========================================
Files 465 465
Lines 108600 108600
===========================================
Hits 87341 87341
Misses 14898 14898
Partials 6361 6361 |
|
/rebuild |
winoros
reviewed
Oct 17, 2019
|
@winoros They are fine because they are not stored directly. |
alivxxx
added
the
status/can-merge
|
/run-all-tests |
|
LGTM |
|
cherry pick to release-3.0 in PR #12817 |
|
cherry pick to release-3.1 in PR #12818 |
sre-bot
added a commit
that referenced
this pull request
Oct 18, 2019
eurekaka
pushed a commit
that referenced
this pull request
Oct 22, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We cannot just store bytes that get from chunk row, it can be rewrited by others.
What is changed and how it works?
Deep copy bytes values that need to be stored directly in stats.
Check List
Tests
Code changes
Side effects
Related changes
Release note