Fix forever hanging when HashAgg is called by apply (#12760) #12765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated cherry pick of #12760 on release-3.1.
What problem does this PR solve?
Fix #12759
What is changed and how it works?
The parent executors(apply) of HashAgg may call
HashAgg.Next
once more to make sure the returned size of chunk is 0.HashAgg.Next
handle these calls incorrectly after its allfinalWorks
exits.On each call of
HashAgg.Next
after the job done, it returns a chunk with 0 size, but put a chk intofinalInputCh
. Each apply executor will call aHashAgg.Next
once more, when the number of parent executors exceeds the channel buffer, the query will hang forever.Explain the example in #12759,
HashAgg.Next
which returns a one-row chunk to its parent, sends the chunk into the buffer (This is valid).HashAgg.Next
called by each of the three apply, which returns a zero-row chunk to its parent, sends the chunk into the buffer (This should not happen).HashAgg.Next
called by the session of tidb, which returns a zero-row chunk to its parent, sends the chunk into the buffer and hangs forever.Check List
Tests
Code changes
Side effects
Related changes
Release note