Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: make sure each streaming response does contain a range entry #12907

Merged
merged 6 commits into from
Oct 28, 2019
Merged

kv: make sure each streaming response does contain a range entry #12907

merged 6 commits into from
Oct 28, 2019

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Oct 23, 2019 •
edited
Loading

What problem does this PR solve?

Part of #12131, This pr is just an enhancement, not a bug fix.
See #12131 (comment)

What is changed and how it works?

Add a strict check to make sure each streaming response does contain a range entry, but not to return wrong results to user.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
mysql> SELECT * FROM t2 WHERE c = 10 ORDER BY a DESC, b DESC;
ERROR 1105 (HY000): streaming response should contain a range entry

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@SunRunAway SunRunAway added type/enhancement The issue or PR belongs to an enhancement. component/tikv labels Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019 •
edited
Loading

Codecov Report

Merging #12907 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12907   +/-   ##
===========================================
  Coverage   80.0396%   80.0396%           
===========================================
  Files           465        465           
  Lines        107403     107403           
===========================================
  Hits          85965      85965           
  Misses        14949      14949           
  Partials       6489       6489

qw4990
qw4990 reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Oct 23, 2019

/run-unit-test

@francis0407
Copy link
Member

/run-unit-test

XuHuaiyu
XuHuaiyu approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/rebuild

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@francis0407
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 606a767 into pingcap:master Oct 28, 2019
@SunRunAway SunRunAway deleted the issues/12131/streaming-2 branch October 28, 2019 05:01
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@SunRunAway @XiaTianliang
kv: make sure each streaming response does contain a range entry (pin…
44323ea 
…gcap#12907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SunRunAway @bb7133 @francis0407 @XuHuaiyu @sre-bot @qw4990