store: when commit get a CommitTsExpired error, retry with a new commitTS
#12980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12980 +/- ##
===========================================
Coverage 80.1441% 80.1441%
===========================================
Files 468 468
Lines 109857 109857
===========================================
Hits 88044 88044
Misses 15106 15106
Partials 6707 6707 |
coocood
reviewed
Oct 29, 2019
coocood
reviewed
Oct 29, 2019
|
LGTM |
MyonKeminta
reviewed
Oct 30, 2019
| c.mu.Lock() | ||
| c.commitTS = commitTS | ||
| c.mu.Unlock() | ||
| return c.commitKeys(bo, batch.keys) |
There was a problem hiding this comment.
I'm kinda afraid that recursion may cause troubles...
There was a problem hiding this comment.
Retry two many times and stack overflow?
There was a problem hiding this comment.
- The old code also take this pattern
- If it's really a problem, we can refactor the code with another PR
There was a problem hiding this comment.
I'm not sure to do we need a backoff here before recursion retry - -? @tiancaiamao if so I will add it at #16061 later
|
@youjiali1995 PTAL |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
coocood
approved these changes
Oct 30, 2019
coocood
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13021 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before we can use non-block read for large transaction, we have to handle the
commitTSproblem:We must guarantee the invariance that
commitTS > minCommitTSThere is an easiest way to handle that:
TiKV return a retryable error and TiDB retrying with a newer
commitTS.What is changed and how it works?
In 2PC commit phase, if TiKV return a
CommitTsExpirederror,TiDBget a new commitTS and retry.Check List
Tests
Side effects