kv: use last range if streaming response does not contain a range entry #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
force-pushed
the
issues/12131/streaming-2
branch
from
5cb38e8
to
6e455f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #13062 +/- ##
===========================================
Coverage 80.0462% 80.0462%
===========================================
Files 468 468
Lines 110270 110270
===========================================
Hits 88267 88267
Misses 15215 15215
Partials 6788 6788 |
SunRunAway
changed the title
SunRunAway
changed the title
SunRunAway
force-pushed
the
issues/12131/streaming-2
branch
from
d3a9a6f
to
d3d6803
Compare
breezewish
approved these changes
Nov 2, 2019
|
BTW note that last range is a range that has already been scanned. |
Exactly. |
mapleFU
approved these changes
Nov 4, 2019
SunRunAway
added
status/can-merge
|
/run-all-tests |
|
@SunRunAway merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 13092 |
|
/run-all-tests |
|
@SunRunAway merge failed. |
|
/merge |
|
/run-all-tests |
This was referenced Nov 7, 2019
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 12, 2019
…upstream-release-2.1
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 12, 2019
…upstream-release-3.0
sre-bot
pushed a commit
that referenced
this pull request
Nov 12, 2019
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 12, 2019
…upstream-release-3.1
sre-bot
pushed a commit
that referenced
this pull request
Nov 12, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #12131, see #12131 (comment)
What is changed and how it works?
use last range if streaming response does contain a range entry
Check List
Tests
Code changes
Side effects
Related changes
Release note