Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use ExtraHandleColumn as PK when generating TablePath (#11959) #13095

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

francis0407
Copy link
Member

@francis0407 francis0407 commented Nov 3, 2019

What problem does this PR solve?

Cherry pick #11959 to branch release-3.0

What is changed and how it works?

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

When the table uses _tidb_rowid as Handle, we can correctly generate a TableScan that keeps the order of _tidb_rowid. For example, select max(_tidb_rowid) from t won't require a Sort anymore.

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

Your auto merge job has been accepted, waiting for 13180

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

@francis0407 merge failed.

@francis0407
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

cherry pick to release-3.1 in PR #13291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants