-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindinfo: correctly handle quotes for bindings sql #13115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13115 +/- ##
=======================================
Coverage 80.1% 80.1%
=======================================
Files 468 468
Lines 110523 110523
=======================================
Hits 88529 88529
Misses 15205 15205
Partials 6789 6789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-3.1 failed |
cherry pick to release-3.0 failed |
What problem does this PR solve?
What is changed and how it works?
The quote is not correctly handled, the result sql cannot be parsed by tidb. This PR reuses the
quote
function logic to handle this case.Check List
Tests
Code changes
Side effects
Related changes
Release note