executor: support innodb_lock_wait_timeout for pessimistic transaction(#13103) #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfzjywxk
added
sig/execution
coocood
reviewed
Nov 6, 2019
session/pessimistic_test.go
Outdated
| tk2.MustExec("commit") | ||
| tk3.MustExec("commit") | ||
|
|
||
| tk.MustQuery(`select * from tk where c1 = 1`).Check(testkit.Rows("1 1")) |
There was a problem hiding this comment.
We can select and check multiple rows.
cfzjywxk
commented
Nov 6, 2019
executor/adapter.go
Outdated
| // txn not found, and before the commit operation other transaction may lock succeed(from the user side, | ||
| // the first transaction did not release lock yet) | ||
| if err != nil { | ||
| newForUpdateTS, tsErr := a.GetTimestampWithRetry(ctx) |
There was a problem hiding this comment.
@coocood Is this appropriate to update forUpdateTs if err != nil (ErrNoWaitSet, ErrLockWaitTimeout ...)
|
LGTM waiting for tikv/tikv#5680 to be picked to release-3.0 |
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13290 |
|
/run-all-tests |
cfzjywxk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
innodb_lock_wait_timeoutsystem variableWhat is changed and how it works?
the kvproto pull request is here link
Check List
Tests
Code changes
Side effects
Related changes
Release note