Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binlog_status for http api and TIDB_SERVERS_INFO table (#13025) #13187

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Add binlog_status for http api and TIDB_SERVERS_INFO table (#13025) #13187

merged 3 commits into from
Nov 8, 2019

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Nov 6, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick #13025
In v3.0.x, we don't have system table named TIDB_SERVERS_INFO , so we can only get binlog status from http api /info/all.

curl http://127.0.0.1:10080/info/all
{
 "servers_num": 1,
 "owner_id": "fc933378-0989-4b5c-bb00-f6ef7242b4a5",
 "is_all_server_version_consistent": true,
 "all_servers_info": {
  "fc933378-0989-4b5c-bb00-f6ef7242b4a5": {
   "version": "5.7.25-TiDB-None",
   "git_hash": "None",
   "ddl_id": "fc933378-0989-4b5c-bb00-f6ef7242b4a5",
   "ip": "",
   "listening_port": 4000,
   "status_port": 10080,
   "lease": "45s",
   "binlog_status": "Off"
  }
 }
}

What is changed and how it works?

Check List

Tests

  • Unit test

Add binlog_status for http api and TIDB_SERVERS_INFO table (pingcap…
b9757e4 
…#13025)

# Conflicts:
#	domain/info.go
#	infoschema/tables.go
#	sessionctx/binloginfo/binloginfo.go
@zier-one
Copy link
Contributor Author

zier-one commented Nov 6, 2019

@tiancaiamao @GregoryIan PTAL

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@zier-one
Copy link
Contributor Author

zier-one commented Nov 8, 2019

/run-all-tests

@IANTHEREAL
Copy link
Contributor

LGTM

@IANTHEREAL IANTHEREAL added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2019
@zier-one
Copy link
Contributor Author

zier-one commented Nov 8, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

Sorry @leoppro, you don't have permission to trigger auto merge event on this branch.

@zier-one
Copy link
Contributor Author

zier-one commented Nov 8, 2019

/run-all-tests

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

Your auto merge job has been accepted, waiting for 13284, 13184

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit cb2b715 into pingcap:release-3.0 Nov 8, 2019
@zier-one zier-one deleted the release-3.0 branch November 8, 2019 11:26
@zier-one zier-one restored the release-3.0 branch January 19, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
component/binlog status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zier-one @tiancaiamao @IANTHEREAL @sre-bot @zimulala