planner: refactor the code of buildUpdate to solve some bugs #13208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
added
type/bugfix
alivxxx
reviewed
Nov 6, 2019
alivxxx
reviewed
Nov 6, 2019
winoros
force-pushed
the
update-refactor
branch
from
1cf8724 to
ae7b8a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #13208 +/- ##
===========================================
Coverage 80.2349% 80.2349%
===========================================
Files 469 469
Lines 112390 112390
===========================================
Hits 90176 90176
Misses 15264 15264
Partials 6950 6950 |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@winoros merge failed. |
|
/run-common-test tidb-test=pr/943 |
|
/run-all-tests tidb-test=pr/943 |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-2.1 failed |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Nov 11, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Nov 11, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Nov 11, 2019
eurekaka
pushed a commit
that referenced
this pull request
Nov 11, 2019
eurekaka
pushed a commit
that referenced
this pull request
Nov 11, 2019
eurekaka
pushed a commit
that referenced
this pull request
Dec 17, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #13201 and fix #13202
What is changed and how it works?
Before entering
buildUpdateLists, the passed argupdateTableListalready used theAsNamedirectly generated from ast.We don't need to get the
AsNamefrom the created plan.Also
extractTableListdidn't reset theDBNamewhen use theAsNameto set theName.Check List
Tests
Related changes
Release note