Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, executor: limit the length of the index name when executing "create table" (#13016) #13310

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 9, 2019

cherry-pick #13016 to release-3.0


What problem does this PR solve?

We don't limit the length of the index name when executing the operation of create table.

What is changed and how it works?

Check the index name's length when calling buildIndexInfo.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Limit the length of the index name when executing "create table"

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 9, 2019

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13309

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4099dc0 into pingcap:release-3.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants