ddl: fix error code and error name #13329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
force-pushed
the
bb7133/fix_ddl_errcode
branch
from
7adf445 to
b4e6561
Compare
|
PTAL @jackysp |
zimulala
reviewed
Nov 11, 2019
ddl/ddl.go
Outdated
| // ErrInvalidTableState returns for invalid Table state. | ||
| ErrInvalidTableState = terror.ClassDDL.New(codeInvalidTableState, "invalid table state") | ||
| ErrInvalidTableState = terror.ClassDDL.New(mysql.ErrInvalidDDLState, fmt.Sprintf(mysql.MySQLErrName[mysql.ErrInvalidDDLState], "table")) |
There was a problem hiding this comment.
Do we need to change the way it is used?
Now we use it like ErrInvalidTableState.GenWithStack("invalid table state %v", tbInfo.State). I think we can use it like ErrInvalidTableState.GenWithStackByArgs(...) in this PR.
bb7133
force-pushed
the
bb7133/fix_ddl_errcode
branch
from
a7ebd44 to
78aa493
Compare
zimulala
added
status/LGT2
bb7133
force-pushed
the
bb7133/fix_ddl_errcode
branch
from
78aa493 to
a7c10d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #13329 +/- ##
===========================================
Coverage 80.3502% 80.3502%
===========================================
Files 469 469
Lines 113793 113793
===========================================
Hits 91433 91433
Misses 15309 15309
Partials 7051 7051 |
bb7133
added
status/LGT3
|
/run-all-tests |
|
@bb7133 merge failed. |
|
mysql-test need to be updated as well |
|
/run-all-tests tidb-test=pr/945 |
bb7133
added
status/all tests passed
and removed
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR refines all
Errors defined inddl/ddl.go:1105(Unknown)error code.8060for all errors caused by invalid DDL object state, for example,ErrInvalidTableStateandErrInvalidDatabaseStateshares error code8060.8050for most errors that caused by the operations that TiDB not supported yet, for example,errRunMultiSchemaChangesanderrCantDropColWithIndex.Related Parser PR: pingcap/parser#630
What is changed and how it works?
NA
Check List
Tests
Code changes
Side effects