Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: specially handle unqiue key when estimate (#13354) #13385

Merged
merged 2 commits into from
Nov 12, 2019
Merged

stats: specially handle unqiue key when estimate (#13354) #13385

merged 2 commits into from
Nov 12, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Nov 12, 2019

Cherry pick #13354
Conflicts： all files.

eurekaka
eurekaka reviewed Nov 12, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Nov 12, 2019

/rebuild

winoros
winoros approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit e318b05 into pingcap:release-2.1 Nov 12, 2019
@alivxxx alivxxx deleted the unique-2.1 branch November 13, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @sre-bot @eurekaka @winoros @zz-jason