Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: fix plugin build and load with go 1.13 (#13455) #13527

Merged
merged 6 commits into from
Nov 27, 2019
Merged

plugin: fix plugin build and load with go 1.13 (#13455) #13527

merged 6 commits into from
Nov 27, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Nov 18, 2019

cherry-pick #13455 to 2.1


This change is Reviewable

@tangenta
Copy link
Contributor

/run-unit-test

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch.

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 21, 2019
@bb7133 bb7133 added this to the v2.1.19 milestone Nov 22, 2019
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

Your auto merge job has been accepted, waiting for 13745

@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

@lysu merge failed.

@jackysp
Copy link
Member

jackysp commented Nov 27, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

@lysu merge failed.

@jackysp
Copy link
Member

jackysp commented Nov 27, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 92f4274 into pingcap:release-2.1 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants