Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: make hint read_from_storage take effect for tikv #13578

Merged
merged 3 commits into from
Nov 20, 2019
Merged

planner: make hint read_from_storage take effect for tikv #13578

merged 3 commits into from
Nov 20, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

As the title says.

What is changed and how it works?

Add the TiKV part for read_from_storage hint.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

@lzmhhh123 lzmhhh123 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #13578 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13578   +/-   ##
===========================================
  Coverage   80.2142%   80.2142%           
===========================================
  Files           472        472           
  Lines        116887     116887           
===========================================
  Hits          93760      93760           
  Misses        15904      15904           
  Partials       7223       7223

alivxxx
alivxxx reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winoros
winoros reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-all-tests

@sre-bot sre-bot merged commit da44428 into pingcap:master Nov 20, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@lzmhhh123 @XiaTianliang
planner: make hint read_from_storage take effect for tikv (pingcap#…
6e20a1e 
…13578)
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Jan 19, 2020
@lzmhhh123
planner: make hint read_from_storage take effect for tikv (pingcap#…
12a9adf 
…13578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @sre-bot @winoros @alivxxx