Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix build on Windows #13650

Merged
merged 2 commits into from
Nov 21, 2019
Merged

*: fix build on Windows #13650

merged 2 commits into from
Nov 21, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 21, 2019

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Cherry-pick #13622 to release 2.1.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick labels Nov 21, 2019
@jackysp jackysp requested review from coocood and imtbkcat November 21, 2019 03:06
@coocood
Copy link
Member

coocood commented Nov 21, 2019

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link

/run-all-tests

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Nov 21, 2019

/run-unit-test

@jackysp jackysp merged commit 4724ab8 into pingcap:release-2.1 Nov 21, 2019
@jackysp jackysp deleted the fix_windows_2.1 branch February 27, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants