config: add configuration entry make TiDB version string configurable #13775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13775 +/- ##
===========================================
Coverage 80.3003% 80.3003%
===========================================
Files 478 478
Lines 118784 118784
===========================================
Hits 95384 95384
Misses 15904 15904
Partials 7496 7496 |
crazycs520
reviewed
Nov 29, 2019
crazycs520
reviewed
Nov 29, 2019
|
/run-unit-test |
bb7133
reviewed
Dec 4, 2019
config/config.toml.example
Outdated
| @@ -74,6 +74,9 @@ split-region-max-num = 1000 | |||
| # In order to support "drop primary key" operation , this flag must be true and the table does not have the pkIsHandle flag. | |||
| alter-primary-key = false | |||
|
|
|||
| # serverVersion is used to show the version of tidb when log in. | |||
There was a problem hiding this comment.
Please add the comment to explain the version when server-version = ""(Original TiDB version)
|
Notice that the result of |
bb7133
added
status/LGT2
bb7133
approved these changes
Dec 4, 2019
|
/run-all-tests |
bb7133
changed the title
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
This was referenced Dec 5, 2019
bb7133
pushed a commit
that referenced
this pull request
Dec 5, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 5, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
It can improve the hard-coding of
serverVersionproperty.What is changed and how it works?
add the
serverVersioninconfig/config.goandconfig/config.toml.exampleCheck List
Tests
Code changes
Release note
server-versionwhich make TiDB version string configurable, this PR closes config：improve the configurability of serverVersion property #13802