privilege: fix privilege check of GRANT ROLE
#13896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
ghost
requested review from
alivxxx and
lzmhhh123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13896 +/- ##
===========================================
Coverage 80.2017% 80.2017%
===========================================
Files 480 480
Lines 119187 119187
===========================================
Hits 95590 95590
Misses 16069 16069
Partials 7528 7528 |
alivxxx
reviewed
Dec 4, 2019
imtbkcat
force-pushed
the
fixRoleAdmin
branch
from
837a1cc
to
5ce7af4
Compare
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Dec 5, 2019
|
/merge |
imtbkcat
added
the
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/run-all-tests tidb-test=pr/963 |
|
/merge |
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
cherry pick to release-3.0 in PR #13932 |
sre-bot
added a commit
that referenced
this pull request
Dec 6, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL,
GRANT roles TO usersrequireROLE_ADMINorSUPERprivilege, But TiDB useGrantPrivto checkGRANT ROLE.What is changed and how it works?
fix this bug and add test.
Check List
Tests
Code changes
Side effects
Related changes
Release note
GRANT ROLE