Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: remove the lower bound of auto analyze ratio #13995

Merged
merged 4 commits into from
Dec 10, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Dec 9, 2019

What problem does this PR solve?

0.3 is too large for auto analyze ratio, some tables cannot be analyzed in time.

What is changed and how it works?

Remove that lower bound.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Remove the restriction of min auto analyze ratio.

@alivxxx alivxxx requested a review from a team as a code owner December 9, 2019 11:15
@ghost ghost removed their request for review December 9, 2019 11:16
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

/run-all-tests

@alivxxx
Copy link
Contributor Author

alivxxx commented Dec 10, 2019

/merge

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #13995 into master will decrease coverage by 0.028%.
The diff coverage is 71.4285%.

@@               Coverage Diff                @@
##             master     #13995        +/-   ##
================================================
- Coverage   80.2073%   80.1792%   -0.0281%     
================================================
  Files           482        481         -1     
  Lines        120752     120596       -156     
================================================
- Hits          96852      96693       -159     
- Misses        16178      16183         +5     
+ Partials       7722       7720         -2

@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 0fe96bc into pingcap:master Dec 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Dec 10, 2019

cherry pick to release-2.1 failed

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants