Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix insert error when convert string to float (#13716) #14009

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Dec 10, 2019

Cherry pick #13716.
Conflicts: logical_plan_builder.go

@eurekaka
Copy link
Contributor

CI fails, PTAL

@zyxbest
Copy link
Contributor

zyxbest commented Dec 10, 2019

/rebuild

1 similar comment
@alivxxx
Copy link
Contributor Author

alivxxx commented Dec 10, 2019

/rebuild

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Dec 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 82e6ea0 into pingcap:release-2.1 Dec 11, 2019
@alivxxx alivxxx deleted the insert-2.1 branch December 12, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants