Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the bug that VIEWs can be dropped by DROP TABLE syntax (#14048) #14052

Merged
merged 6 commits into from
Dec 28, 2019
Merged

ddl: fix the bug that VIEWs can be dropped by DROP TABLE syntax (#14048) #14052

merged 6 commits into from
Dec 28, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 13, 2019

cherry-pick #14048 to release-3.0

What problem does this PR solve?

This PR tries to close #14047

What is changed and how it works?

Add missing checks

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • NA

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the bug that VIEWs can be dropped by DROP TABLE syntax

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 13, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Dec 13, 2019
Merged
djshow832
djshow832 reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2019
wjhuang2016
wjhuang2016 reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjhuang2016 wjhuang2016 added status/LGT2 Indicates that a PR has LGTM 2. component/DDL-need-LGT3 and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 13, 2019
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 17, 2019

Your auto merge job has been accepted, waiting for 14014, 13737

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 17, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 17, 2019

@sre-bot merge failed.

@zyxbest
Copy link
Contributor

zyxbest commented Dec 17, 2019

/run-all-tests

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 19, 2019

Your auto merge job has been accepted, waiting for 14133

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 19, 2019

@sre-bot merge failed.

@zimulala zimulala removed their request for review December 25, 2019 07:13
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 28, 2019

Your auto merge job has been accepted, waiting for 14258, 13878

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 28, 2019

/run-all-tests

@zz-jason zz-jason merged commit 64abbbd into pingcap:release-3.0 Dec 28, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@zz-jason zz-jason zz-jason approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sre-bot @zyxbest @zz-jason @wjhuang2016 @djshow832 @you06 @bb7133