Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocktikv: add the missing ConflictCommitTS #14064

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Dec 16, 2019

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

The ErrConflict filled the wrong conflict ts in mocktikv.

What is changed and how it works?

Fix it.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #14064 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #14064   +/-   ##
===========================================
  Coverage   80.2151%   80.2151%           
===========================================
  Files           483        483           
  Lines        121659     121659           
===========================================
  Hits          97589      97589           
  Misses        16310      16310           
  Partials       7760       7760

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. and removed type/bugfix This PR fixes a bug. labels Dec 16, 2019
@coocood
Copy link
Member

coocood commented Dec 16, 2019

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 16, 2019
@tiancaiamao
Copy link
Contributor

/merge

1 similar comment
@jackysp
Copy link
Member Author

jackysp commented Dec 16, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1dbdc3e into pingcap:master Dec 16, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2019

cherry pick to release-3.0 in PR #14080

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@jackysp jackysp deleted the conflict_ts branch February 27, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants