-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mocktikv: add the missing ConflictCommitTS #14064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #14064 +/- ##
===========================================
Coverage 80.2151% 80.2151%
===========================================
Files 483 483
Lines 121659 121659
===========================================
Hits 97589 97589
Misses 16310 16310
Partials 7760 7760 |
jackysp
added
type/enhancement
The issue or PR belongs to an enhancement.
and removed
type/bugfix
This PR fixes a bug.
labels
Dec 16, 2019
LGTM |
1 similar comment
LGTM |
tiancaiamao
approved these changes
Dec 16, 2019
/merge |
1 similar comment
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 16, 2019
/run-all-tests |
cherry pick to release-3.0 in PR #14080 |
sre-bot
added a commit
that referenced
this pull request
Dec 16, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
The ErrConflict filled the wrong conflict ts in mocktikv.
What is changed and how it works?
Fix it.
Check List
Tests
Code changes
Related changes