expression: solve bug when using string data in Div #14098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhedu
added
type/bugfix
fzhedu
changed the title
SunRunAway
reviewed
Dec 17, 2019
|
I'll add other tests when resolving #14935 |
|
/run-all-tests |
|
@SunRunAway, @zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL. |
1 similar comment
|
@SunRunAway, @zz-jason, @qw4990, @XuHuaiyu, @wshwsh12, PTAL. |
SunRunAway
added
the
priority/release-blocker
zimulala
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix function no longer support string as integer in 3.x #11998
What is changed and how it works?
in arithmeticDivideFunctionClass.setType4DivReal, it set the decimal to 31 while flen is 23. I change the decimal to -1, like in #12858
Check List
Tests
Code changes
Side effects
Related changes
Release note