Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: add plan digest to slow log and slow_query (#14000) #14292

Merged
merged 1 commit into from
Jan 1, 2020
Merged

infoschema: add plan digest to slow log and slow_query (#14000) #14292

merged 1 commit into from
Jan 1, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 31, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick #14000

conflict file.

        both modified:   infoschema/slow_log_test.go
        both modified:   infoschema/tables_test.go
        both modified:   sessionctx/stmtctx/stmtctx.go

AilinKid
AilinKid reviewed Dec 31, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any conflict file?

djshow832
djshow832 reviewed Dec 31, 2019
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 approved these changes Jan 1, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit d84aab8 into pingcap:release-3.0 Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @bb7133 @AilinKid @djshow832