Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix anonymous indexes on the primary column (#14250) #14310

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 2, 2020

cherry-pick #14250 to release-3.0


What problem does this PR solve?

Fix #14243(The results of anonymous indexes created using alter table ... add index on the primary column is inconsistent with MySQL).

What is changed and how it works?

Special handling of anonymous indexes on the primary column.
Remove the duplicate test case.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the result of anonymous indexes created using alter table ... add index on the primary column.

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 2, 2020

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 6, 2020

@sre-bot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Jan 7, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

@sre-bot merge failed.

@zyxbest
Copy link
Contributor

zyxbest commented Jan 7, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

Sorry @qrr1995, you don't have permission to trigger auto merge event on this branch.

@zz-jason
Copy link
Member

zz-jason commented Jan 7, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@zz-jason zz-jason merged commit 3c90149 into pingcap:release-3.0 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants