Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update parser for revamped special comment parser #14389

Merged
merged 4 commits into from
Jan 9, 2020
Merged

go.mod: update parser for revamped special comment parser #14389

merged 4 commits into from
Jan 9, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jan 8, 2020

What problem does this PR solve?

Update parser deps to include pingcap/parser#711.

Fix the integration test broken by that PR.

What is changed and how it works?

The warning message regarding broken optimizer hints was changed. There is a test in this repository against the exact message, and that test is updated in this PR.

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Release note

@kennytm kennytm requested a review from a team as a code owner January 8, 2020 07:07
@ghost ghost requested review from qw4990 and XuHuaiyu and removed request for a team January 8, 2020 07:07
@kennytm
Copy link
Contributor Author

kennytm commented Jan 8, 2020

/run-unit-test #14261

@kennytm
Copy link
Contributor Author

kennytm commented Jan 8, 2020

PTAL @tiancaiamao @tangenta

tangenta
tangenta reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2020
zimulala
zimulala approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

@kennytm merge failed.

@kennytm
Copy link
Contributor Author

kennytm commented Jan 9, 2020

/merge

[2020-01-09T05:16:19.698Z] === RUN   TestInfo
[2020-01-09T05:16:19.698Z] {"level":"warn","ts":"2020-01-09T13:15:58.866+0800","caller":"clientv3/retry_interceptor.go:61","msg":"retrying of unary invoker failed","target":"endpoint://client-a7493aef-aa17-40b5-bf0a-b2ab72c1ccd5/localhost:68172685320723204620","attempt":0,"error":"rpc error: code = Canceled desc = context canceled"}
[2020-01-09T05:16:19.698Z] {"level":"warn","ts":"2020-01-09T13:15:59.330+0800","caller":"clientv3/retry_interceptor.go:61","msg":"retrying of unary invoker failed","target":"endpoint://client-21d504f9-3c1b-49f5-941f-b412beaa548c/localhost:68172685320723204620","attempt":0,"error":"rpc error: code = NotFound desc = etcdserver: requested lease not found"}
[2020-01-09T05:16:19.698Z] --- FAIL: TestInfo (7.21s)
[2020-01-09T05:16:19.698Z]     domain_test.go:161: start syncer failed
[2020-01-09T05:16:19.698Z] FAIL
[2020-01-09T05:16:19.698Z] FAIL	github.com/pingcap/tidb/domain	10.734s

Looks irrelevant

@kennytm
Copy link
Contributor Author

kennytm commented Jan 9, 2020

/run-unit-test

@kennytm
Copy link
Contributor Author

kennytm commented Jan 9, 2020

(test failure was #14415)

@kennytm kennytm added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

@kennytm merge failed.

@tiancaiamao
Copy link
Contributor

/run-unit-test

@kennytm kennytm added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

@kennytm merge failed.

@kennytm
Copy link
Contributor Author

kennytm commented Jan 9, 2020

Same error as #13599 (comment)

@kennytm kennytm added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

Your auto merge job has been accepted, waiting for 14354

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

@kennytm merge failed.

@tiancaiamao
Copy link
Contributor

/run-unit-test

@kennytm
Copy link
Contributor Author

kennytm commented Jan 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

Your auto merge job has been accepted, waiting for 14391

@tiancaiamao tiancaiamao merged commit c90e6a2 into pingcap:master Jan 9, 2020
@kennytm kennytm deleted the fix-integration-test-711 branch January 9, 2020 07:30
tangenta pushed a commit to tangenta/tidb that referenced this pull request Apr 14, 2020
@kennytm @tangenta
go.mod: update parser for revamped special comment parser (pingcap#14389
c3a7d3c 
)

fix parser related integration test
sre-bot pushed a commit that referenced this pull request Apr 20, 2020
@tangenta
go.mod: update parser for revamped special comment parser (#14389) (#…
71abef1 
…16346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@zimulala zimulala zimulala approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/parser component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kennytm @sre-bot @tiancaiamao @zimulala @tangenta @zz-jason