-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: enhance the rule max_min_eliminate to support multiple agg (#12083) #14410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_min_eliminate_3.0 # Conflicts: # planner/core/rule_max_min_eliminate.go
francis0407
added
type/enhancement
The issue or PR belongs to an enhancement.
sig/planner
SIG: Planner
type/3.0 cherry-pick
labels
Jan 9, 2020
francis0407
requested review from
eurekaka and
winoros
and removed request for
eurekaka
January 9, 2020 05:56
eurekaka
reviewed
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
winoros
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #12083
conflicts:
planner/core/rule_max_min_eliminate.go
planner/core/logical_plans.go
planner/core/testdata/plan_suite_out.json
The major difference between release-3.0 and master branch which this PR encounters is:
In master,
But in release-3.0,
AccessPath
does not havefullIdxCols
, so I useexpression.IndexInfo2Cols(p.schema.Columns, path.index)
to generateidxCols
instead.What is changed and how it works?
Check List
Tests
Side effects
Release note
max
/min
.For example,
will be rewritten as