Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json: do not escape html special values #14518

Merged
merged 4 commits into from
Feb 5, 2020
Merged

json: do not escape html special values #14518

merged 4 commits into from
Feb 5, 2020

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jan 17, 2020

What problem does this PR solve?

For

create table test (data JSON);
insert into test (data) values ('{"a":"&"}');
select * from test;

MySQL would have result {"a":"&"}, while tidb shows {"a": "\u0026"}.

What is changed and how it works?

Do not escape the special html values &, > and <.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • do not escape html special values in json

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 19, 2020
@alivxxx alivxxx requested review from coocood and eurekaka February 5, 2020 02:36
@zz-jason
Copy link
Member

zz-jason commented Feb 5, 2020

does release 2.1 have the same issue?

zz-jason
zz-jason reviewed Feb 5, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2020
@alivxxx
Copy link
Contributor Author

alivxxx commented Feb 5, 2020

@zz-jason Yes.

eurekaka
eurekaka approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

Your auto merge job has been accepted, waiting for 14620

@zz-jason zz-jason removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Feb 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit ac8caad into pingcap:master Feb 5, 2020
@sre-bot sre-bot mentioned this pull request Feb 5, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

cherry pick to release-3.0 in PR #14637

@sre-bot sre-bot mentioned this pull request Feb 5, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

cherry pick to release-2.1 in PR #14638

zz-jason pushed a commit that referenced this pull request Feb 5, 2020
@sre-bot
json: do not escape html special values (#14518) (#14638)
8b555ae
@alivxxx alivxxx deleted the json branch February 5, 2020 04:15
sre-bot added a commit that referenced this pull request Feb 5, 2020
@sre-bot
json: do not escape html special values (#14518) (#14637)
f7f504b
hsqlu pushed a commit to hsqlu/tidb that referenced this pull request Feb 8, 2020
@alivxxx @hsqlu
json: do not escape html special values (pingcap#14518)
59e95a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@eurekaka eurekaka eurekaka approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/json status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v3.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @zz-jason @sre-bot @eurekaka @bb7133