Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix json_key not compatible with MySQL #14556

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 20, 2020

What problem does this PR solve?

json_key is not compatible with MySQL

MySQL

mysql> select version();\
+-----------+
| version() |
+-----------+
| 8.0.18    |
+-----------+
1 row in set (0.01 sec)

mysql> SELECT JSON_KEYS('[]');
+-----------------+
| JSON_KEYS('[]') |
+-----------------+
| NULL            |
+-----------------+
1 row in set (0.00 sec)

TiDB

mysql> SELECT JSON_KEYS('[]');
ERROR 3069 (22032): Invalid JSON data provided to function  %s: %s

Check List

Tests

  • Unit test
  • Integration test

Release note

fix json_key not compatible with MySQL

@hawkingrei hawkingrei requested a review from a team as a code owner January 20, 2020 09:50
@ghost ghost requested review from qw4990 and XuHuaiyu and removed request for a team January 20, 2020 09:50
@hawkingrei
Copy link
Member Author

@qw4990 PTAL

Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
@hawkingrei
Copy link
Member Author

/run-all-tests

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 20, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jan 20, 2020

Thanks for your contribution! @hawkingrei

Would you please update the release note from your PR description?

Release note

  • Write release note for bug-fix

It is the note that will be presented to the end-users of TiDB, you can follow the existing release notes from TiDB releases: https://github.com/pingcap/tidb/releases, thanks.

@hawkingrei
Copy link
Member Author

Thanks for your contribution! @hawkingrei

Would you please update the release note from your PR description?

Release note

  • Write release note for bug-fix

It is the note that will be presented to the end-users of TiDB, you can follow the existing release notes from TiDB releases: https://github.com/pingcap/tidb/releases, thanks.

updated

@zz-jason zz-jason added the contribution This PR is from a community contributor. label Jan 20, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

Your auto merge job has been accepted, waiting for 14548

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 664adfe into pingcap:master Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

cherry pick to release-3.0 failed

@hawkingrei
Copy link
Member Author

@zz-jason cherry pick to release-3.0 failed

@zz-jason
Copy link
Member

@hawkingrei would you like to help us to back port the bugfix on non-vectorized implementation of json_keys() to release 3.0 and 2.1?

@hawkingrei
Copy link
Member Author

@hawkingrei would you like to help us to back port the bugfix on non-vectorized implementation of json_keys() to release 3.0 and 2.1?

Yes, Let me try.

hawkingrei added a commit to hawkingrei/tidb that referenced this pull request Jan 21, 2020
hawkingrei added a commit to hawkingrei/tidb that referenced this pull request Jan 21, 2020
@hawkingrei hawkingrei deleted the fix_json_keys branch February 2, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants