Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: support logging rejected connection attempts in audit log (#14594) #14622

Merged
merged 1 commit into from
Feb 5, 2020
Merged

plugin: support logging rejected connection attempts in audit log (#14594) #14622

merged 1 commit into from
Feb 5, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Feb 4, 2020 •
edited
Loading

cherry-pick #14594 to 2.1

This change is Reviewable

@lysu lysu added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick component/plugin labels Feb 4, 2020
@lysu
Copy link
Contributor Author

lysu commented Feb 4, 2020

/run-all-tests

@lysu lysu requested review from imtbkcat and jackysp February 4, 2020 08:08
@lysu lysu removed the type/enhancement The issue or PR belongs to an enhancement. label Feb 4, 2020
jackysp
jackysp reviewed Feb 4, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Feb 5, 2020
@zz-jason zz-jason merged commit 1039390 into pingcap:release-2.1 Feb 5, 2020
@lysu lysu deleted the cp21-reject-audit branch February 5, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

Assignees
No one assigned
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysu @jackysp @zz-jason