Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Fix SMJ hint, support SMJ with descending order (#14505) #14664

Merged
merged 4 commits into from
Feb 25, 2020
Merged

planner: Fix SMJ hint, support SMJ with descending order (#14505) #14664

merged 4 commits into from
Feb 25, 2020

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Feb 6, 2020 •
edited
Loading

What problem does this PR solve?

Cherry-pick #14505 to 3.0

What is changed and how it works?

Changes are brought from #14505

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • Fixing a correctness bug in sort merge join executor, support SMJ in descending order.

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Feb 6, 2020

@SunRunAway PTAL, hand over to you as well~

SunRunAway
SunRunAway reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2020
@SunRunAway SunRunAway added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Feb 24, 2020
zz-jason
zz-jason approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit f68baab into pingcap:release-3.0 Feb 25, 2020
@ichn-hu ichn-hu changed the title planner: Fix SMJ hint, support SMJ with descending order planner: Fix SMJ hint, support SMJ with descending order (cherry-pick #14505) Apr 7, 2020
@ichn-hu ichn-hu changed the title planner: Fix SMJ hint, support SMJ with descending order (cherry-pick #14505) planner: Fix SMJ hint, support SMJ with descending order (#14505) Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@zz-jason zz-jason zz-jason approved these changes

@francis0407 francis0407 Awaiting requested review from francis0407

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@SunRunAway SunRunAway

Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ichn-hu @SunRunAway @sre-bot @zz-jason