executor: support the SELECT INTO ... OUTFILE syntax.
#14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
sig/planner
ghost
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
qw4990
requested review from
wshwsh12,
tiancaiamao,
winoros and
XuHuaiyu
and removed request for
eurekaka and
lzmhhh123
tiancaiamao
reviewed
Feb 19, 2020
|
Rest LGTM |
|
Thanks for your review @tiancaiamao , all comments have been addressed. |
qw4990
requested review from
SunRunAway and
zz-jason
and removed request for
winoros
|
PTAL @tiancaiamao @zz-jason |
|
LGTM |
SunRunAway
reviewed
Feb 24, 2020
|
@SunRunAway Thanks for your review, all comments have been addressed now~ PTAL |
SunRunAway
reviewed
Feb 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #14848 +/- ##
===========================================
Coverage ? 80.2105%
===========================================
Files ? 501
Lines ? 130807
Branches ? 0
===========================================
Hits ? 104921
Misses ? 17585
Partials ? 8301 |
SunRunAway
added
status/can-merge
|
/run-all-tests |
SunRunAway
added
the
release-note
|
Please add the release note section in the PR description. A PR of documentation is appreciated. |
mapleFU
added a commit
to mwish-pingcap-company-repos/tidb
that referenced
this pull request
Feb 25, 2020
…ny-repos/tidb into making-notes * 'making-notes' of https://github.com/mwish-pingcap-company-repos/tidb: planner: change DataSource's type name to 'DataSource' (pingcap#14768) expression: derive collation and charset information and support the Collation() builtin-func (pingcap#14905) util: introduce thread local pool (pingcap#14647) executor: support the `SELECT INTO ... OUTFILE` syntax. (pingcap#14848) expression: disable Duration/JSON related function push down to tiflash (pingcap#14861) planner: move flagPrunColumnsAgain to the last (pingcap#14791) exec: remove duplicate auto-generated test cases (pingcap#14910) planner: distinguish FullScan and the RangeScan in explain/desc info (pingcap#14696) Signed-off-by: mapleFU <1506118561@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #11112.
Support the
SELECT INTO ... OUTFILEsyntax.What is changed and how it works?
SelectIntoto let our planner support this syntax;SelectIntoExec;Check List
Tests