ddl: fix bug of updating tiflash replica status ddl job been stuck. #15001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <crazycs520@gmail.com>
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15001 +/- ##
===========================================
Coverage 80.2220% 80.2220%
===========================================
Files 503 503
Lines 132410 132410
===========================================
Hits 106222 106222
Misses 17814 17814
Partials 8374 8374 |
djshow832
reviewed
Feb 28, 2020
AilinKid
reviewed
Feb 28, 2020
| @@ -748,7 +748,8 @@ func onUpdateFlashReplicaStatus(t *meta.Meta, job *model.Job) (ver int64, _ erro | |||
| } | |||
| if tblInfo.TiFlashReplica == nil || (tblInfo.ID == physicalID && tblInfo.TiFlashReplica.Available == available) || | |||
| (tblInfo.ID != physicalID && available == tblInfo.TiFlashReplica.IsPartitionAvailable(physicalID)) { | |||
There was a problem hiding this comment.
I think it will return nil in UpdateTableReplicaInfo in ddl_api.go rather than return error in onUpdateFlashReplicaStatus at ddl_woker.go.
you mean for the jobs already in queue? do the double check?
Then, may be you should call the onUpdateFlashReplicaStatus directly.
… into fix-update-replica
|
/run-all-tests |
|
/run-all-tests |
zimulala
approved these changes
Mar 4, 2020
zimulala
added
the
status/can-merge
|
/run-unit-test |
|
|
|
/run-unit-test |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Mar 5, 2020
bb7133
pushed a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
Need
cancel DDL jobwhen theupdate flash replicaDDL job need to do nothing.What is changed and how it works?
Check List
Tests
Code changes
Related changes
tidb-ansiblerepositoryRelease note