store: check constraint for "Delete-Your-Writes" records when txn commit (#14968) #15176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/transaction
jackysp
added
the
priority/release-blocker
|
/run-all-tests tikv=pr/7054 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14968 to release-3.0
What problem does this PR solve?
in #9127, we push constraint check down to tikv layer when prewrite phase.
but it miss the situation that txn add record a then delete record a, we also need check record is real duplicate when commit.
so just as
TestDeferConstraintCheckForDelete, it will lead to "delete wrong data"(primary key) or "inconsist index data"(unique key)What is changed and how it works?
we can do a addition batch get check for those key before commit just like pre-#9127 logic
but maybe better to follow #9127's idea just check it with prewrite mutation flag.
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is