expression: fix wrong behavior in values function for Bit(1). #15350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
added
type/bugfix
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15350 +/- ##
===========================================
Coverage 80.3984% 80.3984%
===========================================
Files 502 502
Lines 133984 133984
===========================================
Hits 107721 107721
Misses 17819 17819
Partials 8444 8444 |
qw4990
reviewed
Mar 16, 2020
SunRunAway
reviewed
Mar 18, 2020
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/run-unit-test |
|
cherry pick to release-2.1 in PR #15485 |
|
cherry pick to release-3.0 in PR #15486 |
|
cherry pick to release-3.1 in PR #15487 |
sre-bot
added a commit
that referenced
this pull request
Mar 25, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #15310
What is changed and how it works?
Check the data length in built-in function ValuesInt().
Check List
Tests
Code changes
Side effects
Related changes
Release note
Fix wrong behavior in values function for type bit(n).